Hint on required re-logging to see changed avatar #6483
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
reviewed
Feb 25, 2025
Comment on lines
30
to
+35
| {% trans a_open='<a href="https://support.mozilla.org/en-US/kb/change-primary-email-address-firefox-accounts">'|safe, a_close='</a>'|safe %} | ||
| To change your email or avatar, visit the Mozilla accounts page. {{ a_open }} Learn more. {{ a_close }} | ||
| <br> | ||
| <small>After changing your avatar, please re-login on | ||
| <a href="https://support.mozilla.org/en-US/users/auth">support.mozilla.org</a> to see the changes to apply. | ||
| </small> |
There was a problem hiding this comment.
BTW this would trigger new translations of the whole string, incl. the already existing content in all locales, and the added markup also doesn't really handle well in localization.
A more successful path could be as shown in #5962 — as a new separate string (also with no links etc. complicating it more than necessary…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5446